Joris Vercammen

Latest article: 2024-05-25

Anti-Pattern: Assign in if

In a lot of the code reviews I do, I see the same pattern coming back again that I want to remark on every time I see it. The pattern looks like this: <?php if ($foo = Model::find($id)) { // Do some things with $foo. } else { throw new \Exception('...'); } This code exhibits 2 things that can be improved. We don’t need the else branch and it also does the assign-in-if.